[lvm-devel] master - debug: enhance debug messages

[Zdenek Kabelac]

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e92d3bd1f75d335fba5303c433516ea4ebe5cab1
Commit:        e92d3bd1f75d335fba5303c433516ea4ebe5cab1
Parent:        14e01d6316479a1ee6225010f36d348c103a26c7
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Thu Nov 14 17:00:56 2019 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100

debug: enhance debug messages

---
 lib/label/hints.c |   42 ++++++++++++++++++++++--------------------
 1 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/lib/label/hints.c b/lib/label/hints.c
index 45ab2ff..d913b68 100644
--- a/lib/label/hints.c
+++ b/lib/label/hints.c
@@ -192,7 +192,7 @@ static int _hints_exists(void)
 	if (!stat(_hints_file, &buf))
 		return 1;
 	if (errno != ENOENT)
-		log_debug("hints_exist errno %d", errno);
+		log_sys_debug("stat", _hints_file);
 	return 0;
 }
 
@@ -203,7 +203,7 @@ static int _nohints_exists(void)
 	if (!stat(_nohints_file, &buf))
 		return 1;
 	if (errno != ENOENT)
-		log_debug("nohints_exist errno %d", errno);
+		log_sys_debug("stat", _nohints_file);
 	return 0;
 }
 
@@ -214,7 +214,7 @@ static int _newhints_exists(void)
 	if (!stat(_newhints_file, &buf))
 		return 1;
 	if (errno != ENOENT)
-		log_debug("newhints_exist errno %d", errno);
+		log_sys_debug("stat", _newhints_file);
 	return 0;
 }
 
@@ -225,7 +225,7 @@ static int _touch_newhints(void)
 	if (!(fp = fopen(_newhints_file, "w")))
 		return_0;
 	if (fclose(fp))
-		stack;
+		log_sys_debug("fclose", _newhints_file);
 	return 1;
 }
 
@@ -236,7 +236,7 @@ static int _touch_nohints(void)
 	if (!(fp = fopen(_nohints_file, "w")))
 		return_0;
 	if (fclose(fp))
-		stack;
+		log_sys_debug("fclose", _nohints_file);
 	return 1;
 }
 
@@ -247,26 +247,26 @@ static int _touch_hints(void)
 	if (!(fp = fopen(_hints_file, "w")))
 		return_0;
 	if (fclose(fp))
-		stack;
+		log_sys_debug("fclose", _hints_file);
 	return 1;
 }
 
 static void _unlink_nohints(void)
 {
-	if (unlink(_nohints_file))
-		log_debug("unlink_nohints errno %d", errno);
+	if (unlink(_nohints_file) && errno != ENOENT)
+		log_sys_debug("unlink", _nohints_file);
 }
 
 static void _unlink_hints(void)
 {
-	if (unlink(_hints_file))
-		log_debug("unlink_hints errno %d", errno);
+	if (unlink(_hints_file) && errno != ENOENT)
+		log_sys_debug("unlink", _hints_file);
 }
 
 static void _unlink_newhints(void)
 {
-	if (unlink(_newhints_file))
-		log_debug("unlink_newhints errno %d", errno);
+	if (unlink(_newhints_file) && errno != ENOENT)
+		log_sys_debug("unlink", _newhints_file);
 }
 
 static int _clear_hints(struct cmd_context *cmd)
@@ -275,7 +275,7 @@ static int _clear_hints(struct cmd_context *cmd)
 	time_t t;
 
 	if (!(fp = fopen(_hints_file, "w"))) {
-		log_warn("Failed to clear hint file.");
+		log_warn("WARNING: Failed to clear hint file.");
 		/* shouldn't happen, but try to unlink in case */
 		_unlink_hints();
 		return 0;
@@ -286,10 +286,10 @@ static int _clear_hints(struct cmd_context *cmd)
 	fprintf(fp, "# Created empty by %s pid %d %s", cmd->name, getpid(), ctime(&t));
 
 	if (fflush(fp))
-		log_debug("clear_hints flush errno %d", errno);
+		log_sys_debug("fflush", _hints_file);
 
 	if (fclose(fp))
-		log_debug("clear_hints close errno %d", errno);
+		log_sys_debug("fclose", _hints_file);
 
 	return 1;
 }
@@ -313,7 +313,7 @@ static int _lock_hints(struct cmd_context *cmd, int mode, int nonblock)
 
 	fd = open(_hints_file, O_RDWR);
 	if (fd < 0) {
-		log_debug("lock_hints open errno %d", errno);
+		log_sys_debug("open", _hints_file);
 		return 0;
 	}
 
@@ -641,10 +641,13 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
 	int ret = 1;
 	int i;
 
-	if (!(fp = fopen(_hints_file, "r")))
+	if (!(fp = fopen(_hints_file, "r"))) {
+		if (errno != ENOENT)
+			log_sys_debug("fopen", _hints_file);
 		return 0;
+	}
 
-	log_debug("Reading hint file");
+	log_debug("Reading hint file %s.", _hints_file);
 
 	for (i = 0; i < HINT_LINE_WORDS; i++)
 		split[i] = NULL;
@@ -773,7 +776,7 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
 	}
 
 	if (fclose(fp))
-		stack;
+		log_sys_debug("fclose", _hints_file);
 
 	if (!ret)
 		return 0;
@@ -1354,4 +1357,3 @@ int get_hints(struct cmd_context *cmd, struct dm_list *hints_out, int *newhints,
 
 	return 1;
 }
-