[lvm-devel] stable-2.02 - Revert "dmeventd: avoid bail out preventing repair in raid plugin"

[Heinz Mauelshagen]

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=0585754593d7c010d83274c3a25dd6c3e8c8b4a8
Commit:        0585754593d7c010d83274c3a25dd6c3e8c8b4a8
Parent:        6cad4eba9b8d59cfc78dcaab2fa13de1889367c6
Author:        Heinz Mauelshagen <heinzm at redhat.com>
AuthorDate:    Fri Sep 20 17:48:20 2019 +0200
Committer:     Heinz Mauelshagen <heinzm at redhat.com>
CommitterDate: Fri Sep 20 17:48:48 2019 +0200

Revert "dmeventd: avoid bail out preventing repair in raid plugin"

This reverts commit 9e438b4bc6b9240b63fc79acfef3c77c01a848d8.

The reverted patch also removed the warning which we realized we need
to keep as valuable process information (see related bugzilla below).

In a followup patch, we'll keep the message and avoid bailing out thus
always allowing lvconvert to try repairing if 'allocate' fault policy set.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1751887
---
 daemons/dmeventd/plugins/raid/dmeventd_raid.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/daemons/dmeventd/plugins/raid/dmeventd_raid.c b/daemons/dmeventd/plugins/raid/dmeventd_raid.c
index f435043..52cf43d 100644
--- a/daemons/dmeventd/plugins/raid/dmeventd_raid.c
+++ b/daemons/dmeventd/plugins/raid/dmeventd_raid.c
@@ -76,12 +76,16 @@ static int _process_raid_event(struct dso_state *state, char *params, const char
 	}
 
 	if (dead) {
-		/*
-		 * Use the first event to run a repair ignoring any additonal ones.
-		 *
-		 * We presume lvconvert to do pre-repair
-		 * checks to avoid bloat in this plugin.
-		 */
+		if (status->insync_regions < status->total_regions) {
+			if (!state->warned) {
+				state->warned = 1;
+				log_warn("WARNING: waiting for resynchronization to finish "
+					 "before initiating repair on RAID device %s.", device);
+			}
+
+			goto out; /* Not yet done syncing with accessible devices */
+		}
+
 		if (state->failed)
 			goto out; /* already reported */