[lvm-devel] master - raid: add internal error for no segment

Zdenek Kabelac zkabelac at sourceware.org
Tue Feb 4 16:23:12 UTC 2020


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=67f627c8fbcd5224a1439cbef590e488f6c4823b
Commit:        67f627c8fbcd5224a1439cbef590e488f6c4823b
Parent:        409362c127222640cd2d1fe3e1b62b50867741c1
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Thu Jan 30 15:46:05 2020 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Tue Feb 4 17:22:06 2020 +0100

raid: add internal error for no segment

clang: capture internal error when data_seg would not be defined.
(invalid LV with no areas)
---
 lib/metadata/raid_manip.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 486dea1..dfc6fe5 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -4277,6 +4277,11 @@ static int _raid0_to_striped_retrieve_segments_and_lvs(struct logical_volume *lv
 				return_0;
 		}
 
+		if (!data_seg) {
+			log_error(INTERNAL_ERROR "No segment for %s.", display_lvname(lv));
+			return 0;
+		}
+
 		/* Presumes all data LVs have equal size */
 		area_le += data_seg->len;
 	}





More information about the lvm-devel mailing list