[lvm-devel] master - cov: lvconvert: missing check for function failure

Zdenek Kabelac zkabelac at sourceware.org
Wed May 20 14:03:21 UTC 2020


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=cf74123830250984743d28687e66a0954510b4fa
Commit:        cf74123830250984743d28687e66a0954510b4fa
Parent:        ce8277b47ed95e71e31c933b5c6a35b24dd52756
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Sun May 17 18:29:54 2020 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Wed May 20 15:55:39 2020 +0200

cov: lvconvert: missing check for function failure

---
 tools/lvconvert.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index e969b4459..cf935385f 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -5589,7 +5589,8 @@ static struct logical_volume *_lv_writecache_create(struct cmd_context *cmd,
 
 	memcpy(&seg->writecache_settings, settings, sizeof(struct writecache_settings));
 
-	add_seg_to_segs_using_this_lv(lv_fast, seg);
+	if (!add_seg_to_segs_using_this_lv(lv_fast, seg))
+		return_NULL;
 
 	return lv_wcorig;
 }




More information about the lvm-devel mailing list