[lvm-devel] stable-2.02 - cleanup: avoid unneeded check

Zdenek Kabelac zkabelac at sourceware.org
Fri Oct 16 19:11:54 UTC 2020


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3094c423a0832c703406be3847d561226c19ea10
Commit:        3094c423a0832c703406be3847d561226c19ea10
Parent:        6373a8497776909b548fb5dcfb332b6502868f99
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Sat Sep 26 19:32:52 2020 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Fri Oct 16 17:07:59 2020 +0200

cleanup: avoid unneeded check

Since creation of thin snapshot already makes sure,
the message list is empty, there is no need to check
this again.
---
 lib/metadata/lv_manip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index dbfb306de..341cbbff4 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -8017,8 +8017,7 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg,
 				stack;
 				goto revert_new_lv;
 			}
-		}
-		if (!dm_list_empty(&first_seg(pool_lv)->thin_messages)) {
+		} else if (!dm_list_empty(&first_seg(pool_lv)->thin_messages)) {
 			/* Send message so that table preload knows new thin */
 			if (!lv_is_active(pool_lv)) {
 				/* Avoid multiple thin-pool activations in this case */




More information about the lvm-devel mailing list