[lvm-devel] main - cov: ensure fid is not null

Zdenek Kabelac zkabelac at sourceware.org
Fri Apr 23 21:05:53 UTC 2021


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e1287c3b711d9d77221b0114dbb5ebd84c09ca48
Commit:        e1287c3b711d9d77221b0114dbb5ebd84c09ca48
Parent:        04fd55a0c9e721e8d73f067f886736377ba879e3
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Thu Apr 22 15:11:23 2021 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Fri Apr 23 23:00:55 2021 +0200

cov: ensure fid is not null

---
 tools/pvscan.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/pvscan.c b/tools/pvscan.c
index 83f3f3983..df38e1758 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1232,7 +1232,8 @@ static int _online_devs(struct cmd_context *cmd, int do_all, struct dm_list *pvs
 
 		if (!vg) {
 			log_print("pvscan[%d] PV %s has no VG metadata.", getpid(), dev_name(dev));
-			fmt->ops->destroy_instance(fid);
+			if (fid)
+				fmt->ops->destroy_instance(fid);
 			goto online;
 		}
 




More information about the lvm-devel mailing list