[lvm-devel] main - cov: memleak dir descriptor

Zdenek Kabelac zkabelac at sourceware.org
Tue Jul 27 22:50:29 UTC 2021


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=ec9dd728aa00de692f4b003e12394aa9cdda9446
Commit:        ec9dd728aa00de692f4b003e12394aa9cdda9446
Parent:        308c6f31c3d79b370b163660f3ec38042a00289f
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Tue Jul 27 15:36:48 2021 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Wed Jul 28 00:49:22 2021 +0200

cov: memleak dir descriptor

opendir() missed closedir().
---
 lib/device/dev-type.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/device/dev-type.c b/lib/device/dev-type.c
index 067a9ffad..89791bebe 100644
--- a/lib/device/dev-type.c
+++ b/lib/device/dev-type.c
@@ -180,6 +180,9 @@ int dev_is_used_by_active_lv(struct cmd_context *cmd, struct device *dev, int *u
 		}
 	}
 
+	if (closedir(d))
+		log_sys_debug("closedir", holders_path);
+
 	if (used_by_lv_count)
 		*used_by_lv_count = used_count;
 	if (used_by_dm_name)




More information about the lvm-devel mailing list