[lvm-devel] [LVM2 RFCv2 2/5] lvmlockd: idm: Hook Seagate IDM wrapper APIs

[heming.zhao at suse.com]

On 5/7/21 10:25 AM, Leo Yan wrote:
> To allow the IDM locking scheme be used by users, this patch hooks the
> IDM wrapper; it also introducs a new locking type "idm" and we can use
> it for global lock with option '-g idm'.
> 
> To support IDM locking type, the main change in the data structure is to
> add pvs path arrary.  The pvs list is transferred from the lvm commands,
> when lvmlockd core layer receives message, it extracts the message with
> the keyword "path[idx]".  Finally, the pv list will pass to IDM lock
> manager as the target drives for sending IDM SCSI commands.
> 
> Signed-off-by: Leo Yan <leo.yan at linaro.org>
> ---
>   daemons/lvmlockd/lvmlockd-core.c     | 281 ++++++++++++++++++++++++---
>   daemons/lvmlockd/lvmlockd-internal.h |   4 +-
>   2 files changed, 257 insertions(+), 28 deletions(-)
> 
> diff --git a/daemons/lvmlockd/lvmlockd-core.c b/daemons/lvmlockd/lvmlockd-core.c
> index 094491029..dc213fd93 100644
> --- a/daemons/lvmlockd/lvmlockd-core.c
> +++ b/daemons/lvmlockd/lvmlockd-core.c
> @@ -421,6 +421,63 @@ struct lockspace *alloc_lockspace(void)
>   	return ls;
> ... ...
>   
> @@ -4603,12 +4781,14 @@ static void client_recv_action(struct client *cl)
>   	const char *vg_sysid;
>   	const char *path;
>   	const char *str;
> +	struct pvs pvs;
> +	char buf[11];	/* p a t h [ x x x x ] \0 */
>   	int64_t val;
>   	uint32_t opts = 0;
>   	int result = 0;

Hello

SUSE build tools detected a minor compiling warning/error on the array buf[]:

     [CC] lvmlockd-core.c
gcc -MT lvmlockd-core.o -MMD -MP -MF lvmlockd-core.d -c -I. -I../.. -I../../include -include configure.h -I../../libdaemon/server -I/usr/include/valgrind  -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64  -Wall -Wcast-align -Wfloat-equal -Wformat-security -Winline -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wpointer-arith -Wredundant-decls -Wshadow -Wundef -Wwrite-strings -Wclobbered -Wempty-body -Wignored-qualifiers -Wlogical-op -Wtype-limits -Wsync-nand -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wuninitialized -Wjump-misses-init -Wmissing-parameter-type -Wold-style-declaration -Woverride-init -O2 -g -m64 -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -fPIC -fPIE  -DUSE_SD_NOTIFY  lvmlockd-core.c -o lvmlockd-core.o
lvmlockd-core.c: In function 'client_thread_main':
lvmlockd-core.c:4959:37: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=]
     snprintf(buf, sizeof(buf), "path[%d]", i);
                                      ^~
lvmlockd-core.c:4959:31: note: directive argument in the range [0, 2147483647]
     snprintf(buf, sizeof(buf), "path[%d]", i);
                                ^~~~~~~~~~
In file included from /usr/include/stdio.h:862:0,
                  from ../../device_mapper/all.h:36,
                  from ../../tools/tool.h:22,
                  from lvmlockd-core.c:11:
/usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output between 8 and 17 bytes into a destination of size 11
    return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         __bos (__s), __fmt, __va_arg_pack ());
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/usr/src/packages/BUILD/LVM2.2.03.12/daemons/lvmlockd'
make[1]: *** [../make.tmpl:353: lvmlockd] Error 2
make: *** [make.tmpl:353: daemons] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.y3SyO6 (%build)

Regards
heming