[lvm-devel] [PATCH]pvck: add lock_global() before clean_hint_file() to avoid deadlock

[Wu Guanghao]

Hi,

I found a same problem, pvck command don't add lock_global() before clean_hint_file(), it may cause deadlock.

Signed-off-by: Wu Guanghao <wuguanghao3 at huawei.com>
---
 tools/pvck.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/pvck.c b/tools/pvck.c
index 74663ec43..aba6a9cc8 100644
--- a/tools/pvck.c
+++ b/tools/pvck.c
@@ -3037,6 +3037,9 @@ int pvck(struct cmd_context *cmd, int argc, char **argv)
 	if (arg_is_set(cmd, repairtype_ARG) || arg_is_set(cmd, repair_ARG)) {
 		pv_name = argv[0];

+		if (!lock_global(cmd, "ex"))
+			return ECMD_FAILED;
+
 		clear_hint_file(cmd);

 		if (!setup_device(cmd, pv_name)) {
-- 

Regards

Wu Guanghao