[lvm-devel] dev-next - tests: skip stray testing on real dev dir

David Teigland teigland at sourceware.org
Wed Mar 31 21:49:06 UTC 2021


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=afd43a75f20fbecb047924468c84212f7aefcf0b
Commit:        afd43a75f20fbecb047924468c84212f7aefcf0b
Parent:        a126dde069ada9380ba2f7ab7e520ba4ce3e2a90
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Wed Mar 24 11:57:46 2021 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Wed Mar 24 12:23:07 2021 +0100

tests: skip stray testing on real dev dir

Do not modify /dev dir maintained by udev.
---
 test/shell/stray-device-node.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/shell/stray-device-node.sh b/test/shell/stray-device-node.sh
index 7ed229388..003afb7e8 100644
--- a/test/shell/stray-device-node.sh
+++ b/test/shell/stray-device-node.sh
@@ -18,6 +18,9 @@ SKIP_WITH_LVMPOLLD=1
 aux prepare_devs 3
 get_devs
 
+# Avoid manipulation with real /dev dir
+test "$DM_DEV_DIR" = "/dev" && skip "Skipping stray test on real /dev dir"
+
 cp -r "$dev1" "$DM_DEV_DIR/stray"
 
 vgcreate $SHARED "$vg" "${DEVICES[@]}"
@@ -29,3 +32,5 @@ aux disable_dev "$dev1"
 pvscan
 vgreduce --removemissing --force $vg
 aux enable_dev "$dev1"
+
+rm -f "$DM_DEV_DIR/stray"




More information about the lvm-devel mailing list