[lvm-devel] dev-next - fsadm: fix condition when using --getsize64

David Teigland teigland at sourceware.org
Wed Mar 31 21:49:08 UTC 2021


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=63c58d2a5d935cd78c77f3db13a655e68fb36367
Commit:        63c58d2a5d935cd78c77f3db13a655e68fb36367
Parent:        9684e82cc44cfec66f30b807160c19c06df2a2d8
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Wed Mar 24 16:11:55 2021 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Wed Mar 24 16:34:34 2021 +0100

fsadm: fix condition when using --getsize64

When blocksize --getsize64 gives empty result we want to fallback
to ancient  --getsize * --getss  calculation (RHBZ #1942486).

Reported by: ajschorr at alumni.princeton.edu
---
 scripts/fsadm.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/fsadm.sh b/scripts/fsadm.sh
index d98833c3a..20ae57462 100755
--- a/scripts/fsadm.sh
+++ b/scripts/fsadm.sh
@@ -378,7 +378,7 @@ detect_mounted() {
 detect_device_size() {
 	# check if blockdev supports getsize64
 	DEVSIZE=$("$BLOCKDEV" --getsize64 "$VOLUME" 2>"$NULL" || true)
-	if test -n "$DEVSIZE" ; then
+	if test -z "$DEVSIZE" ; then
 		DEVSIZE=$("$BLOCKDEV" --getsize "$VOLUME" || true)
 		test -n "$DEVSIZE" || error "Cannot read size of device \"$VOLUME\"."
 		SSSIZE=$("$BLOCKDEV" --getss "$VOLUME" || true)




More information about the lvm-devel mailing list