[Ovirt-devel] [PATCH] Setup collectd for performance stats

[Alan Pevec]

Ian Main wrote:
> This patch configures collectd on the host and wui appliance so that it logs performance data via unicast to the wui appliance.  The collectd server is specified via dns srv records the same as other services.
> 
> Signed-off-by: Ian Main <imain at redhat.com>

ACK
just few questions in-line

> diff --git a/ovirt-host-creator/common-post.ks b/ovirt-host-creator/common-post.ks
> index ac3cca1..5ac50c6 100644
> --- a/ovirt-host-creator/common-post.ks
> +++ b/ovirt-host-creator/common-post.ks
> @@ -156,6 +156,12 @@ start() {
>          fi
>      fi
>  
> +    find_srv collectd tcp
> +    if [ -f /etc/collectd.conf.in ]; then

Not sure how could we recover in case SRV lookup fails, but just in case:
+    if [ -f /etc/collectd.conf.in -a $SRV_HOST -a $SRV_PORT ]; then

> +<Plugin network>
> +        Listen "0.0.0.0"
> +</Plugin>

Is there any security on collectd's listening port or anyone can connect?
Not critical if we require separate management network