[Ovirt-devel] [PATCH] create-wui-appliance.sh: minor fixes

Perry N. Myers pmyers at redhat.com
Mon Aug 4 13:19:13 UTC 2008


Jim Meyering wrote:
> I'll probably use the patch below to test the new commit/push hook
> (which I'm about to enable), by appending a space somewhere.
> 
>>From 9a5ab820510ab9ae4430aba7f3fa5f0313bfd085 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering at redhat.com>
> Date: Mon, 4 Aug 2008 11:36:22 +0200
> Subject: [PATCH] create-wui-appliance.sh: minor fixes
> 
> * wui-appliance/create-wui-appliance.sh: Initialize, so that a
> stray KICKSTART=garbage definition in the environment can't
> make this script malfunction.  Change var name to lower case:
> s/KICKSTART/kickstart/.
> Use printf instead of less-portable "echo -n".
> Factor out a common "echo done".

Jim,

Changes look fine so ACK.  One question though, why did you change 
kickstart to lowercase and not IMGDIR?

Perry




More information about the ovirt-devel mailing list