[Ovirt-devel] [PATCH node-image] edit-livecd: optionally append kernel boot params
Alan Pevec
apevec at redhat.com
Tue Dec 2 16:56:29 UTC 2008
Jim Meyering wrote:
> Here's an incremental diff on top of yours.
> It reflects the comments I sent already in this thread,
> fixes a couple more things, and adds a few FIXME comments.
> If this looks ok to you, let me know and I'll amend and push the result.
looks good, go ahead!
> Note the -p PROGRAM-related FIXME.
> When I make that change I'll also realign the --help output.
...
> +# FIXME: instead of requiring a PROGRAM, allow arbitrary shell code,
This is ok for quick changes, but forcing people to write a script has an advantage that they have more persistent trace what changes they did to the image. But anyway, let's have that option.
More information about the ovirt-devel
mailing list