[Ovirt-devel] [PATCH node-image] clean up quoting, cleanup-on-exception, use mktemp-not-/tmp, etc.

Jim Meyering jim at meyering.net
Fri Dec 5 18:49:11 UTC 2008


I've just pushed the following with the two marked corrections:

Jim Meyering <jim at meyering.net> wrote:
> ---
>  ovirt-flash-static |   77 ++++++++++++++++++++++++++++++++++++---------------
>  1 files changed, 54 insertions(+), 23 deletions(-)
>
> diff --git a/ovirt-flash-static b/ovirt-flash-static
...
> +cleanup()
> +{
> +  { umount "$USBTMP"
> +    umount "$SQUASHTMP"
> +    umount "$IMGTMP"
> +  } 2> /dev/null || :
> +  rm -rf "$tmpdir"
> +}
> +trap cleanup 0
> +trap 'Exit $?' 1 2 13 15

s/Exit/exit/

...
> +find "$IMGTMP" # FIXME

Remove the debug "find".




More information about the ovirt-devel mailing list