[Ovirt-devel] [PATCH] Merge developer/bundled appliance into a single appliance: ovirt-appliance

[Perry N. Myers]

Jeff Schroeder wrote:
> On Mon, Jun 30, 2008 at 12:00 AM, Chris Lalancette <clalance at redhat.com> wrote:
> ...snip...
>>> +    chmod a+x $TMPBRCTL
>>> +
>>> +    cat $TMPBRCTL >> /etc/rc.d/rc.local
>>> +
>>> +    $TMPBRCTL
>>> +    rm $TMPBRCTL
>> Is there any reason you need the TMPBRCTL file at all?  Can't you just:
>>
>> cat >> /etc/rc.d/rc.local << EOF
>> brctl addif $BRIDGENAME $bridge # $BRIDGENAME
>> ifconfig $bridge up # $BRIDGENAME
>> EOF
> 
> Either way, you don't make sure /etc/rc.local is executable. The chmod a+x hunk
> should probably be changed to "chmod a+x $TMPBRCTL /etc/rc.local" or something
> similar.

Noted.  I'll add chmod rc.local to the script.

Thanks,

Perry