[Ovirt-devel] [Patch] Fixed Test Cases

Mohammed Morsi mmorsi at redhat.com
Tue Jul 1 04:07:45 UTC 2008


Scott Seago wrote:
> Mohammed Morsi wrote:
>> With this patch, all test cases but one are fixed. The one involves a 
>> quirk when destroying a vm resource pool, where the application 
>> incorrectly tries to unassociate hosts from the pool. This is most 
>> likely due to the hack we had to do where we associated hosts w/ with 
>> the base pools class instead of vm_resource_pools to fix something or 
>> an other. 
>
> Hmm -- what was your exact error here? Although hosts are listed on 
> the base pools  class now, there will never be hosts assigned here, so 
> the "unassociation" should be a no-op. BTW, the reason we had to move 
> the associations to the base class was in order to get :include 
> directives working -- so queries on the base class (i.e. 
> Pool.children, etc.) could automatically include hosts for child 
> Hardware pools -- but hopefully this won't keep tests from working here.
>
> Scott
Looking into it further I see the fixtures are incorrect as there were a 
few hosts which were associated with a vm resource pool id instead of a 
hardware pool id. Changing those to a valid hardware pool resolved the 
last of the issues.

   -Mo




More information about the ovirt-devel mailing list