[Ovirt-devel] [PATCH] Using log rotation to minimize writing to the managed node filesystem.

[Perry N. Myers]

Darryl L. Pierce wrote:
> From: Darryl Pierce <dpierce at redhat.com>
> 
> 
> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
> ---
>  ovirt-host-creator/common-pkgs.ks                  |    1 +
>  ovirt-managed-node/ovirt-managed-node.spec         |   10 ++++++++++
>  ovirt-managed-node/src/logrotate/ovirt-logrotate   |   10 ++++++++++
>  .../src/logrotate/ovirt-logrotate.conf             |   11 +++++++++++
>  4 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100755 ovirt-managed-node/src/logrotate/ovirt-logrotate
>  create mode 100644 ovirt-managed-node/src/logrotate/ovirt-logrotate.conf
> 
> diff --git a/ovirt-host-creator/common-pkgs.ks b/ovirt-host-creator/common-pkgs.ks
> index 8d0ba70..2d1ad6e 100644
> --- a/ovirt-host-creator/common-pkgs.ks
> +++ b/ovirt-host-creator/common-pkgs.ks
> @@ -26,6 +26,7 @@ augeas
>  nc
>  bind-utils
>  syslinux
> +cronie
>  hal
>  ovirt-managed-node
>  -policycoreutils
> diff --git a/ovirt-managed-node/ovirt-managed-node.spec b/ovirt-managed-node/ovirt-managed-node.spec
> index bd807b1..fa943f5 100644
> --- a/ovirt-managed-node/ovirt-managed-node.spec
> +++ b/ovirt-managed-node/ovirt-managed-node.spec
> @@ -36,6 +36,8 @@ make
>  %{__install} -d -m0755 %{buildroot}%{_sysconfdir}/chkconfig.d
>  %{__install} -d -m0755 %{buildroot}%{_initrddir}
>  %{__install} -d -m0755 %{buildroot}%{app_root}
> +%{__install} -d -m0755 %{buildroot}%{_sysconfdir}/cron.hourly
> +%{__install} -d -m0755 %{buildroot}%{_sysconfdir}/logrotate.d
>  
>  %{__install} -p -m0755 scripts/ovirt-awake %{buildroot}%{_sbindir}
>  %{__install} -p -m0755 ovirt-identify-node %{buildroot}%{_sbindir}
> @@ -52,6 +54,9 @@ make
>  
>  %{__install} -p -m0755 scripts/ovirt-setup %{buildroot}%{app_root}
>  
> +%{__install} -p -m0644 logrotate/ovirt-logrotate %{buildroot}%{_sysconfdir}/cron.hourly
> +%{__install} -p -m0644 logrotate/ovirt-logrotate.conf %{buildroot}%{_sysconfdir}/logrotate.d
> +
>  %clean
>  %{__rm} -rf %{buildroot}
>  
> @@ -81,6 +86,8 @@ fi
>  %{_initrddir}/ovirt-post
>  %{_sysconfdir}/kvm-ifup
>  %{_sysconfdir}/dhclient-exit-hooks
> +%config %{_sysconfdir}/logrotate.d/ovirt-logrotate.conf
> +%config %{_sysconfdir}/cron.hourly/ovirt-logrotate
>  %{app_root}/ovirt-setup
>  %defattr(-,root,root,0644)
>  %{_initrddir}/ovirt-functions
> @@ -89,5 +96,8 @@ fi
>  %doc README NEWS AUTHOR ChangeLog
>  
>  %changelog
> +* Wed Jul 02 2008 Darryl Pierce <dpierce at redhat.com> - 0.92 0.2
> +- Added log rotation to limit file system writes.
> +
>  * Mon Jun 30 2008 Perry Myers <pmyers at redhat.com> - 0.92 0.1
>  - Add in sections of kickstart post, general cleanup
> diff --git a/ovirt-managed-node/src/logrotate/ovirt-logrotate b/ovirt-managed-node/src/logrotate/ovirt-logrotate
> new file mode 100755
> index 0000000..f0a2dde
> --- /dev/null
> +++ b/ovirt-managed-node/src/logrotate/ovirt-logrotate
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +
> +/usr/sbin/logrotate /etc/logrotate.d/ovirt-logrotate.conf
> +
> +EXITVALUE=$?
> +if [ $EXITVALUE != 0 ]; then
> +    /usr/bin/logger -t logrotate "ALERT exited abnormally with [$EXITVALUE]"
> +fi
> +exit 0
> +
> diff --git a/ovirt-managed-node/src/logrotate/ovirt-logrotate.conf b/ovirt-managed-node/src/logrotate/ovirt-logrotate.conf
> new file mode 100644
> index 0000000..96fb87c
> --- /dev/null
> +++ b/ovirt-managed-node/src/logrotate/ovirt-logrotate.conf
> @@ -0,0 +1,11 @@
> +/var/log/*.log {
> +    rotate 0
> +    missingok
> +    size=10k
> +}
> +
> +/var/log/messages {
> +    rotate 0
> +    missingok
> +    size=10k
> +}

Sorry for the delay.  ACK

Perry

-- 
|=-        Red Hat, Engineering, Emerging Technologies, Boston        -=|
|=-                     Email: pmyers at redhat.com                      -=|
|=-         Office: +1 412 474 3552   Mobile: +1 703 362 9622         -=|
|=- GnuPG: E65E4F3D 88F9 F1C9 C2F3 1303 01FE 817C C5D2 8B91 E65E 4F3D -=|