[Ovirt-devel] [PATCH] Refactored the ovirt-identify codebase, and added NIC info during the identify phase.

[Alan Pevec]

Works as advertised and node image size-wise is ok: got 47MB ISO and 53M PXE image.

General remarks:
Formating needs to be made consistent e.g.
> +    while(!done)
> +    {
vs
> +        while (count > 0) {

Since you are moving chunks of code around, it's good opportunity to simply run
indent-libvirt from libvirt's HACKING - I guess it makes sense to adopt libvirt's
coding guidelines for oVirt C code.

It might be a good idea to use virBuffer API, also mentioned in libvirt's HACKING file.

As discussed on IRC, I'm a bit worried about adding dependency on HAL, since it's announced to be replaced with DeviceKit and from the thread on the HAL list[1] it's not clear to me that compat HAL API will be maintained in the future.

[1] http://lists.freedesktop.org/archives/hal/2008-May/011560.html