[Ovirt-devel] [PATCH] move collectd runlevel to start after libvirt

[Daniel P. Berrange]

On Thu, Jun 05, 2008 at 12:24:30PM -0400, Hugh O. Brock wrote:
> On Thu, Jun 05, 2008 at 06:02:37PM +0200, Alan Pevec wrote:
> > as reviewer kindly pointed out, we need to create chkconfig.d first
> > and this all must happen in %post not initscript!
> >
> >
> > diff --git a/ovirt-host-creator/common-post.ks b/ovirt-host-creator/common-post.ks
> > index cc64b80..833050a 100644
> > --- a/ovirt-host-creator/common-post.ks
> > +++ b/ovirt-host-creator/common-post.ks
> > @@ -344,7 +344,6 @@ start() {
> >             -e "s/@COLLECTD_PORT@/$SRV_PORT/" $collectd_conf.in \
> >             > $collectd_conf \
> >           || die "Failed to write $collectd_conf"
> > -        service collectd restart
> >     fi
> >
> >     success
> > @@ -364,6 +363,10 @@ EOF
> > chmod +x /etc/init.d/ovirt
> > chkconfig ovirt on
> >
> > +mkdir -p /etc/chkconfig.d
> > +echo "# chkconfig: 345 98 02" > /etc/chkconfig.d/collectd
> > +chkconfig collectd on
> > +
> > echo "Setting up libvirt interfaces"
> > # make libvirtd listen on the external interfaces
> > sed -i -e 's/^#\(LIBVIRTD_ARGS="--listen"\).*/\1/' /etc/sysconfig/libvirtd
> 
> ACK... 
> 
> I guess we can't assume that chkconfig install auto-creates /etc/chkconfig.d?

It should, but it doesn't. Someone should file a BZ against chkconfig to
get them to create /etc/chkconfig.d in the RPM.

Dan.
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|