[Ovirt-devel] [Patch] Graphs Backend

[Hugh O. Brock]

On Thu, Jun 05, 2008 at 03:43:16PM -0400, Mohammed Morsi wrote:
> Mohammed Morsi wrote:
>> Mohammed Morsi wrote:
>>> Mohammed Morsi wrote:
>>>> Attached in Mark's Monitoring API added to the app/util directory and my 
>>>> code interfacing it to generate the graphs. As far as I can tell 
>>>> everything works correctly, but due to my setup, I am getting alot of 
>>>> null datapoints back (this was verified though with the command line 
>>>> rrdtool). If all is well the graphs on the hardware summary page and 
>>>> hosts pages should be done. The graphs on the vm pools summary and vms 
>>>> page as well as the hardware vm pools page (a mirror of the summary 
>>>> snapshot stats for the selected pool) are not done as I am unclear as 
>>>> how to go about this, namely what statistics we need to collect for the 
>>>> vm pool and how to go about doing it (the monitoring API requires a host 
>>>> name, which is easy with hardware pools which contain hosts, but does 
>>>> not make much sense when it comes to vm pools). I can continue hacking 
>>>> away on this once this is resolved.
>>>>
>>>>   -Mo
>>>> ------------------------------------------------------------------------
>

ACK

I have applied this in the interest of moving things forward, with the
following caveats:

1. I had to split the patches and apply them separately from top to
bottom. Don't know why they didn't work as a group, but they did apply
cleanly in the end.

2. A data model change is required: the "state" column must be added
to the hosts table.

3. If you want the app to work, you must either a. run it with real
managed nodes (i.e. on a dev install), or b. make dummy rrd files
under /var/lib/collectd.

Enjoy,
--Hugh