[Ovirt-devel] [PATCH/RFC]: Taskomatic exception cleanup

Alan Pevec apevec at redhat.com
Fri Jun 6 10:09:46 UTC 2008


Chris Lalancette wrote:
> Attached is a rather large patch that cleans up taskomatic exception handling.
> It's quite nice in that it removes a lot of code, and moves almost all exception
> handling code to the top-level, where it really belongs.  This will also give us
> backtraces and good exception messages when things fail.  The only real downside
> to this patch is that I've only lightly tested it so far, and it is a pretty big
> patch for right now.  If people are very against this patch, I can probably come
> up with something smaller (but not as nice) for the time being.  Comments?

Upon careful reading, I say this is a low risk/high benefit change:
+ no change in functionality, just moves the code out of exception blocks
+ very useful for debugging issues

So 1/2 ACK - 2nd half when I actually test it :)




More information about the ovirt-devel mailing list