[Ovirt-devel] Re: [Patch] to write to rails log on stats error

[Hugh O. Brock]

On Fri, Jun 06, 2008 at 02:36:03PM -0400, Mohammed Morsi wrote:
>

> >From 9b9750c3b3d5039622ac1f19053921c73530a79a Mon Sep 17 00:00:00 2001
> From: Mohammed Morsi <mmorsi at redhat.com>
> Date: Fri, 6 Jun 2008 14:33:02 -0400
> Subject: [PATCH] upon Stats error, log warning is now generated
> 
> 
> Signed-off-by: Mohammed Morsi <mmorsi at redhat.com>
> ---
>  wui/src/app/controllers/graph_controller.rb |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/wui/src/app/controllers/graph_controller.rb b/wui/src/app/controllers/graph_controller.rb
> index 729e721..9b83a24 100644
> --- a/wui/src/app/controllers/graph_controller.rb
> +++ b/wui/src/app/controllers/graph_controller.rb
> @@ -134,6 +134,8 @@ class GraphController < ApplicationController
>                      end
>                  end
>              }
> +        else
> +            RAILS_DEFAULT_LOGGER.warn("unable to find collectd/rrd stats for " + stat.get_node?.to_s)
>          end
>      }
>  
> @@ -266,6 +268,8 @@ class GraphController < ApplicationController
>                      end
>                  end
>              }
> +        else
> +            RAILS_DEFAULT_LOGGER.warn("unable to find collectd/rrd stats for " + stat.get_node?.to_s)
>          end
>      }
>      #@snapshots = { :avg  => { :overall_load => 500, :cpu => 10, :in => 100, :out => 1024, :io => 200 },

This will be annoying (which is good) but not cause a DoS (bad), so 

ACK

--Hugh