[Ovirt-devel] [PATCH 3/4] change $FEDORA to shorter $FN

[Jim Meyering]

Chris Lalancette <clalance at redhat.com> wrote:
> Jim Meyering wrote:
>> More reviewability changes.
>>
>>>From 17ed55af8a99cf70ca6fd6e03e741035f38fb7ef Mon Sep 17 00:00:00 2001
>> Date: Sun, 15 Jun 2008 14:51:44 +0200
>> Subject: [PATCH] change $FEDORA to shorter $FN
>
> Hm.  I think I actually prefer FEDORA; it's a little clearer than FN on what it
> is (especially for people, like me, who have never looked at build-all.sh before
> :).  In fact, I might even go so far as to say FEDORANUM or something like that,
> although I think FEDORA is good enough.  What was your intention with the patch?

You called it.
I agree that this one is borderline.

When I first read the name, $FEDORA, I assumed it'd be something else.
At least with $FN, no one will assume ;-)  Plus, changing the name
shrank a line or two (otherwise not trivial to split) to fit within
the 80-col limit.

I too was tempted by a name implying "number" but F_NUM/F_REL sounded
too obscure (though better than FN) and FEDORA_NUM was even longer
than FEDORA.  I'll undo that part.

Change it or leave it as "$FEDORA"?

  F_NUM
  F_REL
  FEDORANUM
  FEDORA_NUM