[Ovirt-devel] [PATCH 1/4] Makefile, build-all adjustments

[Alan Pevec]

Jim Meyering wrote:
> git release, "make bumprelease" no longer works.
> However, a manual "make bumprelease NEWRELEASE=2" does work.

right, need to fix bumprelease to read only till dot in release field
 
> of duplication, eventually I expect to factor those parts
> into a common file and include that file from both places.

yes, we need Makefile.common

> --- a/wui/Makefile
> +++ b/wui/Makefile
> -VERSION		= $(shell echo `awk '{ print $$1 }' version`)
> -NEWVERSION	= $(shell printf "%.2f" `dc -e "$(VERSION) .01 + p"`)

> +VERSION		= $$(awk '{ print $$1 }' version)
> +NEWVERSION	= $$(awk 'BEGIN { printf "%.2f", $(VERSION) + .01 }'))

This fails:
make bumpversion
echo "$(awk 'BEGIN { printf "%.2f", $(awk '{ print $1 }' version) + .01 }')) 0" > version
awk: BEGIN { printf "%.2f", $(awk {
awk:                              ^ syntax error
awk: cmd. line:1: BEGIN { printf "%.2f", $(awk {
awk: cmd. line:1:                               ^ unexpected newline or end of string