[Ovirt-devel] [PATCH] consolidated the storage action links.

[Scott Seago]

Hugh O. Brock wrote:
> On Fri, Jun 27, 2008 at 11:43:13AM -0400, Jason Guiditta wrote:
>   
>> On Wed, 2008-06-18 at 14:09 -0400, Scott Seago wrote:
>>     
>>> Add and Create Storage Pool are now two tabs on the same popup widget. I've also consolidated delete and remove, adding a confirmation dialog for the user to choose which action to take (as specified in the design mockups).
>>>
>>>       
>> Couple things on this.  Generally, works fine for me, but when I click
>> on the new 'Import existing pool(s)' tab, it widens the popup so it
>> hangs off the right side of my screen.  Looking at the markup, I see a
>> element style that has left:358px. Changing this in firebug moves the
>> box where it needs to go.  I took a quick look at the facebox plugin,
>> and it looks like it build that container, so I think either we need to
>> call a function of facebox to recalculate its placement (which is
>> probably the right way), or calculate it ourselves and update the style
>> of the container element (guessing this would be more painful).  The
>> place to do this manipulation would probably be in your show_add and
>> show_new js functions.
>>     
>
> Would this explain the other ff3 problem we were seeing with the
> add-vm dialog exploding off the edge of the screen? Seems like it
> might.
>
> --Hugh
>
>   
Yes, I think this is pre-existing ff3/flexigrid/facebox css problem. 
It's not specific to this popup -- but applies to facebox in general, 
but since it's a pre-exisiting bug we should probably fix it separately.
>> When I click on the above tab, the 'alias' field is also not fully
>> visible, and I cannot expand the column to read it (this may have been
>> an existing bug I never noticed).
>>
>>     
by not fully visible, do you mean it's off the screen to the left? if 
so, that's the same as above -- it's fully visible in ff2. The column 
expanding, however, does seem to be specific to this dialog -- as the 
'add hosts' dialog lets me expand, so I need to track that down here.
>> Lastly, one nit.  While technically you are not required to end
>> javascript lines with a semicolon, in my experience it is generally
>> considered best practice to do so.  I know it might take a little
>> thought hopping back and forth between this and ruby's lack of
>> semicolons, but if there are no major objections, I would like to see us
>> standardize our code to always use them (so would require a few
>> additional changes to this patch).
>>
>>     
Ahh, I was never clear on the best practice there -- but that's fine 
with me. I'd rather not do a wholesale update as lots of things might 
break if they're added incorrectly. It's probably better to update these 
as js functions are created/modified, so each change is sure to be 
tested -- so I'll update the new/modified js functions here.


Scott