[Ovirt-devel] [RFC]: Clean up ovirt-identify-node.c
Chris Lalancette
clalance at redhat.com
Mon Jun 30 11:30:03 UTC 2008
Jim Meyering wrote:
> The above change to safewrite introduces a bug, since not only is "buf"
> a void* pointer (with which doing arithmetic is not portable), but "buf"
> is already incremented just below:
>
> buf = (const char *)buf + r;
Duh. Yes, you are completely right. I increment it here, and then in the
read() call I increment again. Getting rid of the read buf+count is the right
thing to do.
ACK
Chris Lalancette
More information about the ovirt-devel
mailing list