[Ovirt-devel] [PATCH] fix a bug in ovirt-identify-node.c's safewrite function

Jim Meyering meyering at redhat.com
Mon Jun 30 10:46:44 UTC 2008


* ovirt-identify-node.c (safewrite): Revert part of
2d3498a5718931e4239aa223a4ad6ff7f2e08e91.  This function
would malfunction upon any short write.
---
 ovirt-managed-node/src/ovirt-identify-node.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ovirt-managed-node/src/ovirt-identify-node.c b/ovirt-managed-node/src/ovirt-identify-node.c
index 0368717..819f700 100644
--- a/ovirt-managed-node/src/ovirt-identify-node.c
+++ b/ovirt-managed-node/src/ovirt-identify-node.c
@@ -283,7 +283,7 @@ ssize_t safewrite(int fd, const void *buf, size_t count)
 {
         size_t nwritten = 0;
         while (count > 0) {
-                ssize_t r = write(fd, buf+nwritten, count);
+                ssize_t r = write(fd, buf, count);

                 if (r < 0 && errno == EINTR)
                         continue;
--
1.5.6.1.104.g2ff9




More information about the ovirt-devel mailing list