[Ovirt-devel] [PATCH] repost: some cleanup of ovirt-host kickstart to make images smaller

[Chris Lalancette]

Not to nitpick, but a couple of things....

Perry N. Myers wrote:
> 
> Changed to remove /usr/share/i18n completely, added back sunrpc modules 
> and merged with Jim's fix for removing debugging statements.

<snip>

> +fs_mods="9p affs autofs autofs4 befs bfs cifs coda configfs cramfs dlm \
                                                      ^^
I'm not entirely sure what exactly needs configfs in the kernel, but it seems to
be one that we might want to keep around

> +         ecryptfs efs exportfs freevxfs fuse gfs2 hfs hfsplus jbd jbd2 \
> +         jffs jfs minix ncpfs ocfs2 qnx4 reiserfs romfs sysv udf ufs xfs"
> +for dir in $fs_mods ; do
> +   $RM $MODULES/fs/$dir
> +done
> +
> +net_mods="802 8021q 9p appletalk atm ax25 bluetooth dccp decnet \
> +          ieee80211 ipx irda mac80211 netrom rfkill rose sched \
> +          sctp tipc wanrouter wireless"
             ^^
At one point the clustering stuff was using some SCTP code, so we might want to
leave this around.

> +for dir in $net_mods ; do
> +   $RM $MODULES/net/$dir
> +done
> +
> +driver_mods="bluetooth firewire i2c isdn media edac"
                                                  ^^
Probably something we eventually will want to report back to the management
server (via collectd), so we should probably keep these modules too.

> +for dir in $driver_mods ; do
> +   $RM $MODULES/drivers/$dir
> +done

Otherwise, the patch looks fine.  If you do change the above, I don't really
need to see an updated patch....just commit it.

Thanks,
Chris Lalancette