[Ovirt-devel] [Patch] reworked patch for developer version iscsi setup

[Chris Lalancette]

mark wagner wrote:
> Reworked per previous feedback:
> diff --git a/wui-appliance/devel-post.ks b/wui-appliance/devel-post.ks
> index 3ce6239..cc04c4b 100644
> --- a/wui-appliance/devel-post.ks
> +++ b/wui-appliance/devel-post.ks
> @@ -230,3 +230,25 @@ esac
>  EOF
>  chmod +x /etc/init.d/ovirt-app-first-run
>  /sbin/chkconfig ovirt-app-first-run on
> +
> +# Setup the iscsi stuff to be ready on each boot.  Since tgtadm does not use a config file
> +# append what we need to the rc.local file.  Note that this for the developers version only. 
> +
> +cat >> /etc/rc.d/rc.local << \EOF
> +#
> +# Set up the fake iscsi targets
> +tgtadm --lld iscsi --op new --mode target --tid 1 -T node3:disk1
> +tgtadm --lld iscsi --op new --mode target --tid 1 -T node4:disk1
> +tgtadm --lld iscsi --op new --mode target --tid 1 -T node5:disk1

You don't need these last two lines, since I think they are overriding the
target name.  Plus we don't want to call it "node?:disk1" anymore; something
like "ovirtpriv:storage" is a little better.

> +#
> +# Now associate them to the LVs
> +# 
> +tgtadm --lld iscsi --op new --mode logicalunit --tid 1 --lun 1 -b /dev/VolGroup00/iSCSI3
> +tgtadm --lld iscsi --op new --mode logicalunit --tid 1 --lun 2 -b /dev/VolGroup00/iSCSI4
> +tgtadm --lld iscsi --op new --mode logicalunit --tid 1 --lun 3 -b /dev/VolGroup00/iSCSI5

Now that we are using a single target with multiple LUNs, you can actually go
back to calling them iSCSI1, iSCSI2, and iSCSI3 (since that now matches their
LUN).  Otherwise, looks good.

Chris Lalancette