[Ovirt-devel] [Patch] better exceptions for ruby-libvirt bindings

[David Lutterkort]

On Thu, 2008-03-27 at 21:07 -0400, Mohammed Morsi wrote:
> The storage APIs are most likely the problem, I remember seeing related 
> errors when I tried compiling the upstream version.

I committed a change yesterday that makes the bindings build against
libvirt 0.4.0 (i.e., without storage API)

> One question I 
> had was as to the need to pass the virConnectPtr into the _E / vir_error 
> methods. It is not used, yet everything passes it in. If there is no 
> need for it, can it be removed?

I think the initial intent was to use the connection to get more details
about the error through virConnCopyLastError and include that in the
exception being thrown. Do you want to look into that and expand
vir_error accordingly ? That might also be a good way to get to
finer-grained exceptions. Otherwise, yes we should get rid of that extra
connection argument.

David