[Ovirt-devel] [PATCH] split ovirt-wui into separate scripts

[Daniel P. Berrange]

On Thu, May 08, 2008 at 09:36:03AM -0400, Perry N. Myers wrote:
> steve linabery wrote:
> >Hi ovirt,
> >
> >The attached patch attempts to split the ovirt-wui initrd script into
> >5 separate scripts, one for each ovirt daemon.
> >
> >Bullet points:
> >0) names scripts ovirt-host-browser, ovirt-host-keyadd, ... , 
> >ovirt-taskomatic
> >1) adds 'status' option for init scripts
> >2) %post section of rpm spec now removes legacy /etc/init.d/ovirt-wui
> >script if present
> >3) edited rpm spec to handle 5 scripts instead of one where appropriate
> >4) added new service names to the ENABLE_SVCS list in the
> >ovirt-wui-install script
> >
> >The new rpm specfile assumes that the install is a fresh install (i.e.
> >it doesn't attempt to deal with any legacy issues from this patch),
> >with the exception of the convenience removal of the previous
> >ovirt-wui script.
> 
> This looks reasonable, but I have one question.  All of the services are 
> at runlevel 97/03.  Are there any dependencies between these services such 
> that they should start in a predefined order?  If not, then having them 
> all at 97 should be fine.  But previously in the combined ovirt-wui they 
> did start in a specific order.

If there are dependancies they would need to be removed. These 3 services
are conceptually independant pieces, so shouldn't need to be ordered wrt
each other.

Regards,
Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|