[Ovirt-devel] [PATCH] split ovirt-wui into separate scripts

[steve linabery]

On Thu, May 8, 2008 at 11:26 AM, Jim Meyering <jim at meyering.net> wrote:
> "steve linabery" <slinabery at gmail.com> wrote:
>  ...
>  > diff --git a/wui/conf/ovirt-mongrel-rails b/wui/conf/ovirt-mongrel-rails
>  > new file mode 100755
>  > index 0000000..0e5687b
>  > --- /dev/null
>  > +++ b/wui/conf/ovirt-mongrel-rails
>  > @@ -0,0 +1,72 @@
>  > +#!/bin/bash
>  > +#
>  > +#
>  > +# ovirt-mongrel-rails       startup script for ovirt-mongrel-rails
>  > +#
>  > +# chkconfig: - 97 03
>  > +# description: ovirt-mongrel-rails is an essential component of the ovirt VM manager.
>  > +#
>  > +
>  > +OVIRT_DIR=/usr/share/ovirt-wui
>  > +MONGREL_LOG=/var/log/ovirt-wui/mongrel.log
>  > +MONGREL_PID=/var/run/ovirt-wui/mongrel.pid
>  ...
>  > +    if [ $RETVAL -eq 0 ] && touch /var/lock/subsys/ovirt-wui ; then
>  ...
>  > +stop() {
>  ...
>  > +    if [ $RETVAL -eq 0 ] && rm -f /var/lock/subsys/ovirt-wui ; then
>
>  Hi Steve,
>  I know this is mostly just moving existing code around, but this is
>  probably as good a time as any to factor out that repeated lock file name.
>

Third time charm?

I also pulled out the mongrel_rails executable name, since having it
down there in the status line was making me nervous.

Good day,
Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: daemonsplit.patch
Type: text/x-patch
Size: 11056 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080508/67589744/attachment.bin>