[Ovirt-devel] [PATCH] Add support of image files for NFS Storage Pool during xml vm creation

[Pierre Inglebert]

Le lundi 19 mai 2008 à 15:17 +0200, Chris Lalancette a écrit :
> Pierre Inglebert wrote:
> > Hi,
> > This is my first contribution to the oVirt project and not the last one
> > ( i will talk about that in my next email ).
> > This patch adds support of image files for NFS Storage Pool during the
> > xml vm creation because it is actually hard coded for an iSCSI Pool.
> 
> Thanks for your contribution!
> 
> I *thought* I had tested taskomatic working with both iSCSI and NFS.  The way it
> works is that we mount the volume properly on the managed node, and then always
> point the XML at either the path for NFS (i.e. /mnt/foo/guest.img) or the dev
> device for iSCSI (i.e. /dev/disk/by/id/iscsi-blah-blah).
> 
> However, it's possible that I didn't get it totally right, or I thought I tested
> something I really didn't.  What exact problem did you face, and how does this
> patch solve it?
> 
> Chris Lalancette
> 
> _______________________________________________
> Ovirt-devel mailing list
> Ovirt-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/ovirt-devel
> 

For my test, i didn't mount anything by hand and i had this error : 
"libvir: QEMU error : internal error invalid domain type attribute"

This is a part of the file generated by task_vm.rb :
<disk device='disk' type='block'>
	<source dev='/mnt/Au01ryHYWx27WywX/debian.4-0.img'/>
	<target dev='hda'/>
</disk>

As you can see when you create the xml in task_vm.rb, in the <devices>
node when you try to add a NFS disk, it creates a disk with type "block"
and a source "dev=/your/path" and that don't work with NFS, you need a
file type and a source "file=/your/image.iso"