[Ovirt-devel] LDAP fallback

[Hugh O. Brock]

On Tue, May 20, 2008 at 11:14:20AM -0400, Darryl L. Pierce wrote:
> Hugh O. Brock wrote:
>>> From where do you run the script and do you have /usr/share/ovirt-wui on 
>>> that machine? The active_record_env.rb is expecting the code to be 
>>> located in /usr/share/ovirt-wui and, from there, loads dependencies.
>>
>> I ran it from /usr/share/ovirt-wui/script/ . But, surely we shouldn't
>> be depending on the cwd being correct for the script to work?
>
> It shouldn't, no, since the above source file explicitly sets the load path 
> to an absolute directory.
>
> (edit)
>
> Maybe I spoke too soon? The require calls are *above* where the script 
> defines the OVIRT_DIR variable. I'll fix this.
>
>>> On a side note, I did see where a line in the script where the permission 
>>> is being created was reverted to :user rather than :uid. I'm pushing the 
>>> fixed version of that.
>>
>> Sounds good, I'll look for the patch...
>
> I didn't send a patch but pushed it instead. Should I have done a patch?
>

Yes, please post everything to the list and get an ACK before
committing unless the commit is *utterly* trivial (a typo fix, for
example). Thanks!

--H