[Ovirt-devel] [Patch] round 1 of ajax form validation

Hugh O. Brock hbrock at redhat.com
Thu May 22 17:19:26 UTC 2008


On Thu, May 22, 2008 at 12:25:15PM -0400, Scott Seago wrote:
> Take 2...

> >From aedf4c1257fc53dbcb8eb057e47d728ab4a3be1c Mon Sep 17 00:00:00 2001
> From: Scott Seago <sseago at redhat.com>
> Date: Thu, 22 May 2008 12:16:40 -0400
> Subject: [PATCH] ok, now we have some ajax form validation.
> 
> I haven't gone crazy with validation rules -- mostly left things as they were, but added a few more validates_presence_of bits in the models.
> create methods now return a json response with the field errors, if there are any. I haven't tested base-level error messages (i.e. general errors not connected to a form field) -- I'll probably need to make a couple more changes to support that. But basic field-level errors are being reported fine.
> 
> Also, for any of the action links/popups requiring grid checkboxes, I've added client-side validation to only perform the action if at least one box is checked -- displaying an error popup if there aren't any.
> 

ACK, and committed. N.B. the error message still reads "{%fn} cannot be blank on the 'create new pool' popup..."

Thanks,
--Hugh




More information about the ovirt-devel mailing list