[Ovirt-devel] [PATCH] Fix so libvirt does not start default network interface on developer/bundled

[Jim Meyering]

Alan Pevec <apevec at redhat.com> wrote:

>>> --disabled=iptables,yum-updatesd,libvirtd,bluetooth,cups,gpm,pcscd,NetworkManager,NetworkManagerDispatcher
>>> --enabled=ntpd,httpd,postgresql,ovirt-wui,tgtd,nfs,collectd,network
>>> +services
>>> --disabled=libvirtd,postgresql,iptables,yum-updatesd,bluetooth,cups,gpm,pcscd,NetworkManager,NetworkManagerDispatcher
>>> --enabled=network,tgtd,nfs
>>
>> Hmm.  Why is --enabled reduced to just network, tgtd and nfs?  What
>> about ntpd, httpd, etc??
> They'll be enabled and started after they are configured in ovirt-wui-install
>
>>> -OVIRT_SVCS="ovirt-host-browser ovirt-host-status \
>>> -            ovirt-taskomatic ovirt-host-keyadd ovirt-mongrel-rails"
>>> -ENABLE_SVCS="ntpd httpd postgresql libvirtd"
>>> +OVIRT_SVCS="ovirt-host-browser ovirt-host-keyadd ovirt-host-status \
>>> +            ovirt-mongrel-rails ovirt-taskomatic"
>>
>> Did you reorder OVIRT_SVCS just to alphabetize it?  :)
> yeah, doesn't matter really, just looks better to my squared mind :)

same here ;-) slightly more maintainable, too.
If it's sorted, it's harder to accidentally insert a duplicate.
Speaking of maintainability, I've come to prefer to make such lists
one per line, if they get much longer (this is borderline).

If you use single quotes rather than double quotes, the reader
doesn't have to wonder if there's something like a $var or `cmd`
reference hidden in the list of literals.
With either type of quote, you can omit the trailing backslashes.

OVIRT_SVCS='
  ovirt-host-browser
  ovirt-host-keyadd
  ovirt-host-status
  ovirt-mongrel-rails
  ovirt-taskomatic
'