[Ovirt-devel] [PATCH ovirt-node-image] build procedure change: include image ISO in SRPM

[Alan Pevec]

Daniel P. Berrange wrote:
> On Tue, Nov 04, 2008 at 03:40:14PM +0100, Alan Pevec wrote:
>> livecd images cannot be built in Koji build-system at the moment,
>> they need to be included in SRPM
>>
>> Signed-off-by: Alan Pevec <apevec at redhat.com>
> 
> NACK.
> 
> In doing this you are no longer testing ISO image creation in
> the automated builds.

but I changed autobuild.sh too, so it does create the ISO image
 
> The existing core functionality of the SPEC file shouldn't
> be removed.

> There should be a conditional in the spec file to let you
> optionally build the RPM with a pre-built ISO.

ok, that's a good idea, I'll add that