[Ovirt-devel] [PATCH] add 'state' field to storage pools and volumes

Chris Lalancette clalance at redhat.com
Fri Nov 7 07:27:35 UTC 2008


Scott Seago wrote:
> I've added a state field to StoragePool and StorageVolume. When initially
> created, pools and volumes are in the pending_setup state -- once taskomatic
> is done they're 'available'. Upon deletion, they go into pending_deletion
> until taskomatic is done.
> 
> Taskomatic changes to take this into account have not yet been included,
> since clalance's LVM patch hasn't been pushed.
> 

This all looks reasonable, and is very much inline with what I thought it would
be.  At least for an initial cut, the states:

STATE_PENDING_SETUP    = "pending_setup"
STATE_PENDING_DELETION = "pending_deletion"
STATE_AVAILABLE        = "available"

should be sufficient to close the races we've thought of so far.  We can always
add more later.

Oh, I'll be pushing my taskomatic LVM code today (with a few of the changes
sseago suggested in his review).  So then we'll be able the taskomatic side of
this change.

ACK

-- 
Chris Lalancette




More information about the ovirt-devel mailing list