[Ovirt-devel] Re: [PATCH appliance] Move appliance creation out of spec file to Makefile

[Alan Pevec]

Perry Myers wrote:
> -ln -s %{ovirt_cache_dir}/appliance-tmp tmp
> +	ln -s $(OVIRT_CACHE_DIR)/$(PACKAGE)-tmp tmp

ln -snf ... otherwise it fails 2nd time

prolly not worth optimizing, but due to tmpdir name change (appliance-tmp -> ovirt-appliance-tmp) Fedora image will be re-downloaded ( ~100MB )

> -sudo su - -c "cd $(pwd) && appliance-creator --config ovirt-appliance.ks \
> +	sudo -E appliance-creator --config $(PACKAGE).ks \

appliance-creator assumes grub in PATH, so this fails when installing grub. Until appliance-tools is fixed, workaround could be to modify PATH before running sudo