[Ovirt-devel] [PATCH node] RSyslog configuration for standalone mode.

[Jim Meyering]

Bryan Kearney <bkearney at redhat.com> wrote:
> It looks for a DNS service locator record by default, and lets the
> user override if desired. Supports setting the maximum log file size. Includes comments from Alan Pevec and Jim Meyering.
> ---
>  scripts/ovirt-config-logging |  143 ++++++++++++++++++++++++++++++++++++++++++
>  scripts/ovirt-config-setup   |    2 +
>  2 files changed, 145 insertions(+), 0 deletions(-)

ACK, modulo two nits:

> +function prompt_user {
> +    while true ; do
...
> +            printf "\n Max Logfile Size: $MAX_LOG_SIZE"           <<<

The trailing blanks above would make your "push" fail.

...
> +         printf "found! Useing server '$DEFAULT_SERVER:$DEFAULT_PORT'.\n"

s/ei/i/