[Ovirt-devel] [PATCH server] Implement "poweroff" in the WUI.

Chris Lalancette clalance at redhat.com
Tue Nov 18 06:38:16 UTC 2008

Scott Seago wrote:
> Chris Lalancette wrote:
>> Implement the concept of "poweroff" for VMs in the WUI, and in the backend
>> taskomatic bits.  This is the counterpart to "shutdown"; while
>> shutdown does a graceful shutdown of the guest (with an ACPI event), poweroff
>> pull the plug.  This is necessary for situations in which the guest
>> doesn't understand the ACPI event (like 2.4 based Linux guests), where the
>> ACPI event fails for some reason, or where you just want to pull the plug.
>> Signed-off-by: Chris Lalancette <clalance at redhat.com>
>> ---
>>  src/app/controllers/resources_controller.rb |    3 ++-
>>  src/app/models/vm.rb                        |    3 +++
>>  src/app/models/vm_task.rb                   |    9 +++++++++
>>  src/task-omatic/task_vm.rb                  |   22 ++++++++++++----------
>>  src/task-omatic/taskomatic.rb               |    1 +
>>  5 files changed, 27 insertions(+), 11 deletions(-)
>  From a reviewing the code it looks like a reasonable approach. I 
> haven't had a chance to test it yet, but if you've tested it in an 
> appliance, then ACK. Otherwise I'll fire up an appliance tomorrow and 
> test it out.

Thanks for the review.  I did test it out, and it seemed to do the right things
in my testing.  I mostly just wanted to make sure the minor model changes were
fine.  I'll push this now.

Chris Lalancette

More information about the ovirt-devel mailing list