[Ovirt-devel] Re: [PATCH node] Added support for local storage configuration.

[Jim Meyering]

Alan Pevec <apevec at redhat.com> wrote:
> Darryl L. Pierce wrote:
>> +++ b/scripts/ovirt-config-storage
> ...
>> +if [ "$1" == "AUTO" ]; then
>> +    DRIVE=$OVIRT_VOL
> OVIRT_VOL -> OVIRT_INIT  (will be set by ovirt-early when parsing boot params)
>
> vars set by ovirt-early with partition sizes are:
> OVIRT_VOL_BOOT
> OVIRT_VOL_SWAP
> OVIRT_VOL_ROOT
> OVIRT_VOL_CONFIG
> OVIRT_VOL_LOGGING
>
> This part was modified in the follow up patch, so Jim please amend: OVIRT_(.*)_SIZE -> OVIRT_VOL_\1

Rather, here's an incremental that retains the _SIZE suffix:

diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index 81dadef..54d6e42 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -231,10 +231,10 @@ esac
 MEM_SIZE=$(echo "scale=0; $MEM_SIZE / 1024" | bc -l)
 SWAP_SIZE=$MEM_SIZE

-BOOT_SIZE=${OVIRT_BOOT_SIZE=$default_boot_size}
-ROOT_SIZE=${OVIRT_ROOT_SIZE=$default_root_size}
-LOGGING_SIZE=${OVIRT_LOGGING_SIZE=$default_logging_size}
-CONFIG_SIZE=${OVIRT_CONFIG_SIZE=$default_config_size}
+BOOT_SIZE=${OVIRT_VOL_BOOT_SIZE=$default_boot_size}
+ROOT_SIZE=${OVIRT_VOL_ROOT_SIZE=$default_root_size}
+LOGGING_SIZE=${OVIRT_VOL_LOGGING_SIZE=$default_logging_size}
+CONFIG_SIZE=${OVIRT_VOL_CONFIG_SIZE=$default_config_size}

 if [ "$1" == "AUTO" ]; then
     # In "AUTO" mode, OVIRT_VOL should be defined in the environment.