[Ovirt-devel] [PATCH]: Add NFS file creation/deletion to taskomatic

Chris Lalancette clalance at redhat.com
Wed Nov 26 15:31:36 UTC 2008

Chris Lalancette wrote:
>> You shouldn't have to set the lvm_pool_id for the source volume, as 
>> you've already set that relationship from the other side. When the 
>> lvm_pool was saved, the source_volume <-> lvm_pool association was 
>> saved into the database. Did you run into any particular problems 
>> without the latter code? From what I see here, we're essentially 
>> setting (and saving) that association twice.
> I have to go back and look at it.  I'm pretty sure the lvm_pool_id 
> wasn't being set properly, so I wasn't able to go from the given LVM 
> volume -> LVM Pool -> source volume in taskomatic.

Not that I doubted you, but I went back and checked, and it turns out you were 
right about this.  At the time I added this, I must have been running into one 
of my own bugs.  So I've removed this bit of code (I still left the change from 
LvmPool.new to StoragePool.factory, though).  I'll send out an updated patch 

Chris Lalancette

More information about the ovirt-devel mailing list