[Ovirt-devel] [PATCH server] Fixed the tests for host-browser.

[Darryl Pierce]

Mohammed Morsi wrote:
>>  BuildRequires: ruby-devel
>> +BuildRequires: ruby-flexmock
>>  BuildRequires: ruby-gettext-package
>>  BuildRequires: rubygem(rake) >= 0.7
>>  Provides: ovirt-server
>>   
> git-am reported some conflict with this file when I applied the patch.
> Luckily this file contained a simple one line change so I was able to
> manually copy it over and remove the file from the patch.

Weird. I only added the ruby-flexmock dependency since it's come up a
few times.

>> diff --git a/src/test/unit/host_browser_awaken_test.rb b/src/test/unit/host_browser_awaken_test.rb
>> index 5340e01..55a3458 100644
>> --- a/src/test/unit/host_browser_awaken_test.rb
>> +++ b/src/test/unit/host_browser_awaken_test.rb
>> @@ -64,7 +64,7 @@ class HostBrowserAwakenTest < Test::Unit::TestCase
>>    # Ensures that the server is satisfied if the remote system is
>>    # making a wakeup call.
>>    #
>> -  def test_get_mode_with_awaken_request
>> +  def test_get_mode_with_awaken_request    
>>   
> Same issue with trailing whitespace here.

I made sure to remove trailing whitespaces in these files since they'd
creeped in previously.

> 
> 
>>      @session.should_receive(:write).with("MODE?\n").once().returns { |request| request.length }
>>      @session.should_receive(:readline).once().returns { "AWAKEN\n" }
>>  
>>   
> 
> 
> After applying the patch, I tried running the test cases but to no
> avail, many were still broken. 

This patch was only to fix the HostBrowser tests, none others; such bugs
as the one to do with @first_id are outside of its scope. The tests that
I fixed with this run without error.

I'm sending an updated patch now.

-- 
Darryl L. Pierce <dpierce at redhat.com> : GPG KEYID: 6C4E7F1B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dpierce.vcf
Type: text/x-vcard
Size: 319 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20081002/0da8853d/attachment.vcf>