[Ovirt-devel] [PATCH server] Fixed the tests for host-browser.

[Darryl Pierce]

Mohammed Morsi wrote:
> ACK, with a few caveats.
> 
> Applying this patch once again complains about whitespace issues. It
> didn't affect my testing it as it applied fine, and figure you'll catch
> this as if you try to push with extraneous whitespace our repo won't let
> you.
> 

Gah, I'm starting to hate this editor (Netbeans) for the whitespaces.
I've removed the whitespaces and will push without them.

> This takes care of all the outstanding errors I noticed up to this
> point. Unfortunately it seems that since these nic / browser issues are
> fixed, other errors are now apparent, particularly that pertaining to
> bonding. I attached the output of my 'rake test' run, so as to help in
> debugging. It seems the most prominent issue is 'type_id' which is
> attempted to be set in the bonding_test "setup" method, but which
> doesn't exist in the bondings database table. The last three errors
> (6,7,8) seem to indicate another problem which I'm not sure the cause of.

I'll fix that test shortly.

-- 
Darryl L. Pierce <dpierce at redhat.com> : GPG KEYID: 6C4E7F1B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dpierce.vcf
Type: text/x-vcard
Size: 319 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20081002/0ad4bc2e/attachment.vcf>