[Ovirt-devel] [PATCH server] Added a link from bonding to a boot type.

[Chris Lalancette]

Darryl L. Pierce wrote:
> Previously the bondings had one of two paths: it could either
> explicitly set a static IP address or else fallback to an implicit
> DHCP boot.
> 
> This change will require that bondings be explicitly configured
> in the same way as a standard network interface.
> 
> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
> ---
>  src/app/models/bonding.rb                      |   10 +++++++
>  src/db/migrate/023_add_boot_type_to_bonding.rb |   31 ++++++++++++++++++++++++
>  src/test/fixtures/bondings.yml                 |    1 +
>  src/test/unit/bonding_test.rb                  |   20 +++++++++++----
>  4 files changed, 57 insertions(+), 5 deletions(-)
>  create mode 100644 src/db/migrate/023_add_boot_type_to_bonding.rb

Yes, this is reasonable.  I like things to be a little more explicit, so having
an explicit "DHCP" (as opposed to implicit) makes things better.

ACK
-- 
Chris Lalancette