[Ovirt-devel] [PATCH server] Added support for booting a VM from an ISO image.

[Jim Meyering]

Darryl Pierce <dpierce at redhat.com> wrote:
> Chris Lalancette wrote:
>>> -  devs = [ 'hda', 'hdb', 'hdc', 'hdd' ]
>>> -  i = 0
>>> +  devs = [ 'hda', 'hdb', 'hdd', 'hde', 'hdf' ]
>>
>> This can't work.  As it stands now, the qemu device model has 2 IDE controllers
>> with a master/slave per controller, for a maximum of 4 devices.  That's
>> generally what hardware has (had) as well, and nobody is really interested in
>> pushing that up.  We really need to switch to using SCSI and/or virtio, but
>> until we do, you can't just add an hdf; it has no chance of working.
>
> Done. But, we'll want to make sure there's some logic added to the VM
> creation page to disallow adding more than four storage devices.
>
>>> +  which_device = 0
>>>    diskDevices.each do |disk|
>>> +    is_cdrom = (disk =~ /\.iso/) ? true : false
>>> +    <<<=========

Hi Darryl,

I noticed that that line would add trailing spaces
(for me, they're highlighted).
You'll want to remove them and any others before pushing.
That will save you the trouble of an automatically-rejected push attempt.