[Ovirt-devel] [PATCH node-image] avoid image-minimizer fall-out

[Daniel P. Berrange]

On Wed, Oct 08, 2008 at 10:42:47AM -0400, Bryan Kearney wrote:
> Daniel P. Berrange wrote:
> >On Wed, Oct 08, 2008 at 03:08:50PM +0200, Jim Meyering wrote:
> >>>From 8e45eb82fb7ed450de78e48aeaa8bd34b04313e1 Mon Sep 17 00:00:00 2001
> >>From: Jim Meyering <meyering at redhat.com>
> >>Date: Wed, 8 Oct 2008 14:59:31 +0200
> >>Subject: [PATCH node-image] ovirt-node-image.ks (%post): Include 
> >>common-post.ks last
> >>
> >>I noticed the following error go by today:
> >>
> >>    Removing blacklisted files and directories
> >>    Cleanup empty directory structures in /usr/share
> >>    Running image-minimizer...
> >>==> Unknown Command: touch
> >
> >The image minimiser should immediately exit with non-zero status
> >upon errors, not merely print a warning which could be missed in
> >the line noise for months.
> 
> This is the current behavior (it returns a 1). I believe that the ks 
> file continues. HUFF... can you see if you are eating the return code in 
> the appliance-creator?

Perhaps the kickstart file needs a 'set -e' as its first shell command ?
Or maybe the livecd-tools which invoke the %post section are not 
validating the exit status / throwing an error. 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|