[Ovirt-devel] [PATCH node] Updated the configuration processing to remove the need for scripts.

[Darryl Pierce]

Jim Meyering wrote:
> "Darryl L. Pierce" <dpierce at redhat.com> wrote:
>> The system now takes an encoded configuration descriptor from the server. It
>> then parses from that a set of aliases for bondings if such exist. It then
>> also extracts configuration details for the various network interfaces on the
>> node. Afterward, it reloads module dependencies and then restarts the
>> networking service.
> ...
>> diff --git a/scripts/ovirt-process-config b/scripts/ovirt-process-config
> ...
>> +modconf=$(awk '/bonding=/ {
> 
> Hi Darryl,
> 
> A couple of nit-picky details:
> 
> This should be anchored at beginning of line,
> so as not to match a commented-out line:
> 
>     modconf=$(awk '/^[ \t]*bonding=/ {

I incorporated that into the processing script, as well as the long
string replacement. Thank you for the feedback. :)

-- 
Darryl L. Pierce <dpierce at redhat.com> : GPG KEYID: 6C4E7F1B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dpierce.vcf
Type: text/x-vcard
Size: 319 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20081014/88cd634c/attachment.vcf>